Selecting correct carton based on qty
I'm attempting to create a function that will select the correct carton based on the qty of the carton content.
Here are my cartons that have the number of items they can hold:
SMALL_PASCAL = 300
BIG_PASCAL = 600
BABY_BOX = 1200
A485_1201 = 1800
A4140_1901 = 3000
A485 = 5000
And here is the method that will return the CartonType
:
/// <summary>
/// Get Carton Type
/// </summary>
/// <param name="qty"></param>
/// <returns></returns>
[Test]
private static CartonType GetCartonType(int qty)
{
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 300 && qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 600 && qty <= 1200)
{
return CartonType.BABY_BOX;
}
else if (qty > 1200 && qty <= 1800)
{
return CartonType.A485_1201;
}
else if (qty >1800 && qty <=3000)
{
return CartonType.A4140_1901;
}
else // 5000 or more.
{
return CartonType.A485;
}
}
Calling the method like so:
int qty = 1540;
Console.WriteLine(GetCartonType(qty));
Output:
A485_1201
Is there a better way to achieve this rather than an if
statement? Also, I just had a thought that what if the qty is like 10,000? I would then require 2 A485.
c#
add a comment |
I'm attempting to create a function that will select the correct carton based on the qty of the carton content.
Here are my cartons that have the number of items they can hold:
SMALL_PASCAL = 300
BIG_PASCAL = 600
BABY_BOX = 1200
A485_1201 = 1800
A4140_1901 = 3000
A485 = 5000
And here is the method that will return the CartonType
:
/// <summary>
/// Get Carton Type
/// </summary>
/// <param name="qty"></param>
/// <returns></returns>
[Test]
private static CartonType GetCartonType(int qty)
{
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 300 && qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 600 && qty <= 1200)
{
return CartonType.BABY_BOX;
}
else if (qty > 1200 && qty <= 1800)
{
return CartonType.A485_1201;
}
else if (qty >1800 && qty <=3000)
{
return CartonType.A4140_1901;
}
else // 5000 or more.
{
return CartonType.A485;
}
}
Calling the method like so:
int qty = 1540;
Console.WriteLine(GetCartonType(qty));
Output:
A485_1201
Is there a better way to achieve this rather than an if
statement? Also, I just had a thought that what if the qty is like 10,000? I would then require 2 A485.
c#
add a comment |
I'm attempting to create a function that will select the correct carton based on the qty of the carton content.
Here are my cartons that have the number of items they can hold:
SMALL_PASCAL = 300
BIG_PASCAL = 600
BABY_BOX = 1200
A485_1201 = 1800
A4140_1901 = 3000
A485 = 5000
And here is the method that will return the CartonType
:
/// <summary>
/// Get Carton Type
/// </summary>
/// <param name="qty"></param>
/// <returns></returns>
[Test]
private static CartonType GetCartonType(int qty)
{
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 300 && qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 600 && qty <= 1200)
{
return CartonType.BABY_BOX;
}
else if (qty > 1200 && qty <= 1800)
{
return CartonType.A485_1201;
}
else if (qty >1800 && qty <=3000)
{
return CartonType.A4140_1901;
}
else // 5000 or more.
{
return CartonType.A485;
}
}
Calling the method like so:
int qty = 1540;
Console.WriteLine(GetCartonType(qty));
Output:
A485_1201
Is there a better way to achieve this rather than an if
statement? Also, I just had a thought that what if the qty is like 10,000? I would then require 2 A485.
c#
I'm attempting to create a function that will select the correct carton based on the qty of the carton content.
Here are my cartons that have the number of items they can hold:
SMALL_PASCAL = 300
BIG_PASCAL = 600
BABY_BOX = 1200
A485_1201 = 1800
A4140_1901 = 3000
A485 = 5000
And here is the method that will return the CartonType
:
/// <summary>
/// Get Carton Type
/// </summary>
/// <param name="qty"></param>
/// <returns></returns>
[Test]
private static CartonType GetCartonType(int qty)
{
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 300 && qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 600 && qty <= 1200)
{
return CartonType.BABY_BOX;
}
else if (qty > 1200 && qty <= 1800)
{
return CartonType.A485_1201;
}
else if (qty >1800 && qty <=3000)
{
return CartonType.A4140_1901;
}
else // 5000 or more.
{
return CartonType.A485;
}
}
Calling the method like so:
int qty = 1540;
Console.WriteLine(GetCartonType(qty));
Output:
A485_1201
Is there a better way to achieve this rather than an if
statement? Also, I just had a thought that what if the qty is like 10,000? I would then require 2 A485.
c#
c#
edited Dec 17 at 4:42
Heslacher
44.9k460155
44.9k460155
asked Dec 16 at 23:01
user1234433222
20010
20010
add a comment |
add a comment |
3 Answers
3
active
oldest
votes
Is there a better way to achieve this rather than an If statement?
Yes. You could have an enumeration of the container types and their capacities, in increasing order by capacity,
loop over in order,
and as soon as you find one that's big enough, return it.
It's perhaps easier to see after you simplify the if-else chain,
by removing redundant conditions, for example:
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
if (qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
if (qty <= 1200)
{
return CartonType.BABY_BOX;
}
// ...
do you have any suggestion if there is for anything over 5000? so eg the largest box and a small pascal could be required?
– user1234433222
Dec 16 at 23:21
2
@user1234433222 sure, but we don't implement feature requests here... You could subtract from the quantity the capacity of the selected container, and then call the method again.
– janos
Dec 16 at 23:23
Thanks for that, working backwards might be the key to this.
– user1234433222
Dec 16 at 23:24
add a comment |
Bug
There is a bug in your example where you are using SMALL_PASCAL
twice:
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 300 && qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
More flexibility with free mappings
I would take a different approach for the other answer. Quantities are something that might change in time or be different in different contexts so I wouldn't use them as enum
or const
values but instead created a pure enum
first:
public enum CartonType
{
Undefined = 0,
SMALL_PASCAL,
BIG_PASCAL,
BABY_BOX,
A485_1201,
A4140_1901,
A485,
Default = A485
}
where there are two new items: Undefined
and Default
- that we can conveniently use in a new extension method. It would map Quantity
to CartonType
for any collection:
public static CartonType GetCartonType(this int quantity, IEnumerable<(int Quantity, CartonType Type)> mappings)
{
var mapping = mappings.FirstOrDefault(m => quantity <= m.Quantity);
return
mapping.Type == CartonType.Undefined
? CartonType.Default
: mapping.Type;
}
With this you can specify different quantities if necessary and use them as a parameter:
var quantityCartonTypeMappings = new(int Quantity, CartonType Type)
{
(300, CartonType.SMALL_PASCAL),
(600, CartonType.BIG_PASCAL),
};
var quantity = 700;
var cartonType = quantity.GetCartonType(quantityCartonTypeMappings);
add a comment |
I am not a big fan of "smart" enum
because they do not scale well (what if you will have a more complex logic?) and they force you to spread business logic all around in your code. Because of this - in most cases - I'd suggest to use the approach in t3chb0t's answer ("mapping" might be even moved to a separate configuration/rule file).
For simple cases you have, however, an easier approach:
enum CartonType
{
SMALL_PASCAL = 300,
BIG_PASCAL = 600,
BABY_BOX = 1200,
A485_1201 = 1800,
A4140_1901 = 3000,
A485 = 5000,
}
CartonType GetCartonType(int quantity)
{
return Enum.GetValues(typeof(CartonType))
.Cast<CartonType?>()
.OrderByDescending(x => x)
.LastorDefault(x => quantity <= (int)x) ?? CartonType.A485;
}
I don't like that CartonType.A485
hard-coded default then you might need to make it slightly more complex:
CartonType GetCartonType(int quantity)
{
var types = Enum.GetValues(typeof(CartonType));
var biggest = types.Cast<CartonType>().Max();
return types
.Cast<CartonType?>()
.OrderByDescending(x => x)
.LastOrDefault(x => quantity <= (int)x) ?? biggest;
}
Simply used like this:
Debug.Assert(GetCartonQuantity(100) == CartonType.SMALL_PASCAL);
Debug.Assert(GetCartonQuantity(1000) == CartonType.BABY_BOX);
Debug.Assert(GetCartonQuantity(10000) == CartonType.A485);
Note: if you put this "business knowledge" inside your enum
then you must write proper tests not only for GetCartonQuantity()
but also for CartonType
itself (to be sure values are consistent).
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209788%2fselecting-correct-carton-based-on-qty%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
3 Answers
3
active
oldest
votes
3 Answers
3
active
oldest
votes
active
oldest
votes
active
oldest
votes
Is there a better way to achieve this rather than an If statement?
Yes. You could have an enumeration of the container types and their capacities, in increasing order by capacity,
loop over in order,
and as soon as you find one that's big enough, return it.
It's perhaps easier to see after you simplify the if-else chain,
by removing redundant conditions, for example:
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
if (qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
if (qty <= 1200)
{
return CartonType.BABY_BOX;
}
// ...
do you have any suggestion if there is for anything over 5000? so eg the largest box and a small pascal could be required?
– user1234433222
Dec 16 at 23:21
2
@user1234433222 sure, but we don't implement feature requests here... You could subtract from the quantity the capacity of the selected container, and then call the method again.
– janos
Dec 16 at 23:23
Thanks for that, working backwards might be the key to this.
– user1234433222
Dec 16 at 23:24
add a comment |
Is there a better way to achieve this rather than an If statement?
Yes. You could have an enumeration of the container types and their capacities, in increasing order by capacity,
loop over in order,
and as soon as you find one that's big enough, return it.
It's perhaps easier to see after you simplify the if-else chain,
by removing redundant conditions, for example:
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
if (qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
if (qty <= 1200)
{
return CartonType.BABY_BOX;
}
// ...
do you have any suggestion if there is for anything over 5000? so eg the largest box and a small pascal could be required?
– user1234433222
Dec 16 at 23:21
2
@user1234433222 sure, but we don't implement feature requests here... You could subtract from the quantity the capacity of the selected container, and then call the method again.
– janos
Dec 16 at 23:23
Thanks for that, working backwards might be the key to this.
– user1234433222
Dec 16 at 23:24
add a comment |
Is there a better way to achieve this rather than an If statement?
Yes. You could have an enumeration of the container types and their capacities, in increasing order by capacity,
loop over in order,
and as soon as you find one that's big enough, return it.
It's perhaps easier to see after you simplify the if-else chain,
by removing redundant conditions, for example:
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
if (qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
if (qty <= 1200)
{
return CartonType.BABY_BOX;
}
// ...
Is there a better way to achieve this rather than an If statement?
Yes. You could have an enumeration of the container types and their capacities, in increasing order by capacity,
loop over in order,
and as soon as you find one that's big enough, return it.
It's perhaps easier to see after you simplify the if-else chain,
by removing redundant conditions, for example:
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
if (qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
if (qty <= 1200)
{
return CartonType.BABY_BOX;
}
// ...
answered Dec 16 at 23:10
janos
97.2k12124350
97.2k12124350
do you have any suggestion if there is for anything over 5000? so eg the largest box and a small pascal could be required?
– user1234433222
Dec 16 at 23:21
2
@user1234433222 sure, but we don't implement feature requests here... You could subtract from the quantity the capacity of the selected container, and then call the method again.
– janos
Dec 16 at 23:23
Thanks for that, working backwards might be the key to this.
– user1234433222
Dec 16 at 23:24
add a comment |
do you have any suggestion if there is for anything over 5000? so eg the largest box and a small pascal could be required?
– user1234433222
Dec 16 at 23:21
2
@user1234433222 sure, but we don't implement feature requests here... You could subtract from the quantity the capacity of the selected container, and then call the method again.
– janos
Dec 16 at 23:23
Thanks for that, working backwards might be the key to this.
– user1234433222
Dec 16 at 23:24
do you have any suggestion if there is for anything over 5000? so eg the largest box and a small pascal could be required?
– user1234433222
Dec 16 at 23:21
do you have any suggestion if there is for anything over 5000? so eg the largest box and a small pascal could be required?
– user1234433222
Dec 16 at 23:21
2
2
@user1234433222 sure, but we don't implement feature requests here... You could subtract from the quantity the capacity of the selected container, and then call the method again.
– janos
Dec 16 at 23:23
@user1234433222 sure, but we don't implement feature requests here... You could subtract from the quantity the capacity of the selected container, and then call the method again.
– janos
Dec 16 at 23:23
Thanks for that, working backwards might be the key to this.
– user1234433222
Dec 16 at 23:24
Thanks for that, working backwards might be the key to this.
– user1234433222
Dec 16 at 23:24
add a comment |
Bug
There is a bug in your example where you are using SMALL_PASCAL
twice:
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 300 && qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
More flexibility with free mappings
I would take a different approach for the other answer. Quantities are something that might change in time or be different in different contexts so I wouldn't use them as enum
or const
values but instead created a pure enum
first:
public enum CartonType
{
Undefined = 0,
SMALL_PASCAL,
BIG_PASCAL,
BABY_BOX,
A485_1201,
A4140_1901,
A485,
Default = A485
}
where there are two new items: Undefined
and Default
- that we can conveniently use in a new extension method. It would map Quantity
to CartonType
for any collection:
public static CartonType GetCartonType(this int quantity, IEnumerable<(int Quantity, CartonType Type)> mappings)
{
var mapping = mappings.FirstOrDefault(m => quantity <= m.Quantity);
return
mapping.Type == CartonType.Undefined
? CartonType.Default
: mapping.Type;
}
With this you can specify different quantities if necessary and use them as a parameter:
var quantityCartonTypeMappings = new(int Quantity, CartonType Type)
{
(300, CartonType.SMALL_PASCAL),
(600, CartonType.BIG_PASCAL),
};
var quantity = 700;
var cartonType = quantity.GetCartonType(quantityCartonTypeMappings);
add a comment |
Bug
There is a bug in your example where you are using SMALL_PASCAL
twice:
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 300 && qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
More flexibility with free mappings
I would take a different approach for the other answer. Quantities are something that might change in time or be different in different contexts so I wouldn't use them as enum
or const
values but instead created a pure enum
first:
public enum CartonType
{
Undefined = 0,
SMALL_PASCAL,
BIG_PASCAL,
BABY_BOX,
A485_1201,
A4140_1901,
A485,
Default = A485
}
where there are two new items: Undefined
and Default
- that we can conveniently use in a new extension method. It would map Quantity
to CartonType
for any collection:
public static CartonType GetCartonType(this int quantity, IEnumerable<(int Quantity, CartonType Type)> mappings)
{
var mapping = mappings.FirstOrDefault(m => quantity <= m.Quantity);
return
mapping.Type == CartonType.Undefined
? CartonType.Default
: mapping.Type;
}
With this you can specify different quantities if necessary and use them as a parameter:
var quantityCartonTypeMappings = new(int Quantity, CartonType Type)
{
(300, CartonType.SMALL_PASCAL),
(600, CartonType.BIG_PASCAL),
};
var quantity = 700;
var cartonType = quantity.GetCartonType(quantityCartonTypeMappings);
add a comment |
Bug
There is a bug in your example where you are using SMALL_PASCAL
twice:
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 300 && qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
More flexibility with free mappings
I would take a different approach for the other answer. Quantities are something that might change in time or be different in different contexts so I wouldn't use them as enum
or const
values but instead created a pure enum
first:
public enum CartonType
{
Undefined = 0,
SMALL_PASCAL,
BIG_PASCAL,
BABY_BOX,
A485_1201,
A4140_1901,
A485,
Default = A485
}
where there are two new items: Undefined
and Default
- that we can conveniently use in a new extension method. It would map Quantity
to CartonType
for any collection:
public static CartonType GetCartonType(this int quantity, IEnumerable<(int Quantity, CartonType Type)> mappings)
{
var mapping = mappings.FirstOrDefault(m => quantity <= m.Quantity);
return
mapping.Type == CartonType.Undefined
? CartonType.Default
: mapping.Type;
}
With this you can specify different quantities if necessary and use them as a parameter:
var quantityCartonTypeMappings = new(int Quantity, CartonType Type)
{
(300, CartonType.SMALL_PASCAL),
(600, CartonType.BIG_PASCAL),
};
var quantity = 700;
var cartonType = quantity.GetCartonType(quantityCartonTypeMappings);
Bug
There is a bug in your example where you are using SMALL_PASCAL
twice:
if (qty <= 300)
{
return CartonType.SMALL_PASCAL;
}
else if (qty > 300 && qty <= 600)
{
return CartonType.SMALL_PASCAL;
}
More flexibility with free mappings
I would take a different approach for the other answer. Quantities are something that might change in time or be different in different contexts so I wouldn't use them as enum
or const
values but instead created a pure enum
first:
public enum CartonType
{
Undefined = 0,
SMALL_PASCAL,
BIG_PASCAL,
BABY_BOX,
A485_1201,
A4140_1901,
A485,
Default = A485
}
where there are two new items: Undefined
and Default
- that we can conveniently use in a new extension method. It would map Quantity
to CartonType
for any collection:
public static CartonType GetCartonType(this int quantity, IEnumerable<(int Quantity, CartonType Type)> mappings)
{
var mapping = mappings.FirstOrDefault(m => quantity <= m.Quantity);
return
mapping.Type == CartonType.Undefined
? CartonType.Default
: mapping.Type;
}
With this you can specify different quantities if necessary and use them as a parameter:
var quantityCartonTypeMappings = new(int Quantity, CartonType Type)
{
(300, CartonType.SMALL_PASCAL),
(600, CartonType.BIG_PASCAL),
};
var quantity = 700;
var cartonType = quantity.GetCartonType(quantityCartonTypeMappings);
answered Dec 17 at 9:14
t3chb0t
34.1k746114
34.1k746114
add a comment |
add a comment |
I am not a big fan of "smart" enum
because they do not scale well (what if you will have a more complex logic?) and they force you to spread business logic all around in your code. Because of this - in most cases - I'd suggest to use the approach in t3chb0t's answer ("mapping" might be even moved to a separate configuration/rule file).
For simple cases you have, however, an easier approach:
enum CartonType
{
SMALL_PASCAL = 300,
BIG_PASCAL = 600,
BABY_BOX = 1200,
A485_1201 = 1800,
A4140_1901 = 3000,
A485 = 5000,
}
CartonType GetCartonType(int quantity)
{
return Enum.GetValues(typeof(CartonType))
.Cast<CartonType?>()
.OrderByDescending(x => x)
.LastorDefault(x => quantity <= (int)x) ?? CartonType.A485;
}
I don't like that CartonType.A485
hard-coded default then you might need to make it slightly more complex:
CartonType GetCartonType(int quantity)
{
var types = Enum.GetValues(typeof(CartonType));
var biggest = types.Cast<CartonType>().Max();
return types
.Cast<CartonType?>()
.OrderByDescending(x => x)
.LastOrDefault(x => quantity <= (int)x) ?? biggest;
}
Simply used like this:
Debug.Assert(GetCartonQuantity(100) == CartonType.SMALL_PASCAL);
Debug.Assert(GetCartonQuantity(1000) == CartonType.BABY_BOX);
Debug.Assert(GetCartonQuantity(10000) == CartonType.A485);
Note: if you put this "business knowledge" inside your enum
then you must write proper tests not only for GetCartonQuantity()
but also for CartonType
itself (to be sure values are consistent).
add a comment |
I am not a big fan of "smart" enum
because they do not scale well (what if you will have a more complex logic?) and they force you to spread business logic all around in your code. Because of this - in most cases - I'd suggest to use the approach in t3chb0t's answer ("mapping" might be even moved to a separate configuration/rule file).
For simple cases you have, however, an easier approach:
enum CartonType
{
SMALL_PASCAL = 300,
BIG_PASCAL = 600,
BABY_BOX = 1200,
A485_1201 = 1800,
A4140_1901 = 3000,
A485 = 5000,
}
CartonType GetCartonType(int quantity)
{
return Enum.GetValues(typeof(CartonType))
.Cast<CartonType?>()
.OrderByDescending(x => x)
.LastorDefault(x => quantity <= (int)x) ?? CartonType.A485;
}
I don't like that CartonType.A485
hard-coded default then you might need to make it slightly more complex:
CartonType GetCartonType(int quantity)
{
var types = Enum.GetValues(typeof(CartonType));
var biggest = types.Cast<CartonType>().Max();
return types
.Cast<CartonType?>()
.OrderByDescending(x => x)
.LastOrDefault(x => quantity <= (int)x) ?? biggest;
}
Simply used like this:
Debug.Assert(GetCartonQuantity(100) == CartonType.SMALL_PASCAL);
Debug.Assert(GetCartonQuantity(1000) == CartonType.BABY_BOX);
Debug.Assert(GetCartonQuantity(10000) == CartonType.A485);
Note: if you put this "business knowledge" inside your enum
then you must write proper tests not only for GetCartonQuantity()
but also for CartonType
itself (to be sure values are consistent).
add a comment |
I am not a big fan of "smart" enum
because they do not scale well (what if you will have a more complex logic?) and they force you to spread business logic all around in your code. Because of this - in most cases - I'd suggest to use the approach in t3chb0t's answer ("mapping" might be even moved to a separate configuration/rule file).
For simple cases you have, however, an easier approach:
enum CartonType
{
SMALL_PASCAL = 300,
BIG_PASCAL = 600,
BABY_BOX = 1200,
A485_1201 = 1800,
A4140_1901 = 3000,
A485 = 5000,
}
CartonType GetCartonType(int quantity)
{
return Enum.GetValues(typeof(CartonType))
.Cast<CartonType?>()
.OrderByDescending(x => x)
.LastorDefault(x => quantity <= (int)x) ?? CartonType.A485;
}
I don't like that CartonType.A485
hard-coded default then you might need to make it slightly more complex:
CartonType GetCartonType(int quantity)
{
var types = Enum.GetValues(typeof(CartonType));
var biggest = types.Cast<CartonType>().Max();
return types
.Cast<CartonType?>()
.OrderByDescending(x => x)
.LastOrDefault(x => quantity <= (int)x) ?? biggest;
}
Simply used like this:
Debug.Assert(GetCartonQuantity(100) == CartonType.SMALL_PASCAL);
Debug.Assert(GetCartonQuantity(1000) == CartonType.BABY_BOX);
Debug.Assert(GetCartonQuantity(10000) == CartonType.A485);
Note: if you put this "business knowledge" inside your enum
then you must write proper tests not only for GetCartonQuantity()
but also for CartonType
itself (to be sure values are consistent).
I am not a big fan of "smart" enum
because they do not scale well (what if you will have a more complex logic?) and they force you to spread business logic all around in your code. Because of this - in most cases - I'd suggest to use the approach in t3chb0t's answer ("mapping" might be even moved to a separate configuration/rule file).
For simple cases you have, however, an easier approach:
enum CartonType
{
SMALL_PASCAL = 300,
BIG_PASCAL = 600,
BABY_BOX = 1200,
A485_1201 = 1800,
A4140_1901 = 3000,
A485 = 5000,
}
CartonType GetCartonType(int quantity)
{
return Enum.GetValues(typeof(CartonType))
.Cast<CartonType?>()
.OrderByDescending(x => x)
.LastorDefault(x => quantity <= (int)x) ?? CartonType.A485;
}
I don't like that CartonType.A485
hard-coded default then you might need to make it slightly more complex:
CartonType GetCartonType(int quantity)
{
var types = Enum.GetValues(typeof(CartonType));
var biggest = types.Cast<CartonType>().Max();
return types
.Cast<CartonType?>()
.OrderByDescending(x => x)
.LastOrDefault(x => quantity <= (int)x) ?? biggest;
}
Simply used like this:
Debug.Assert(GetCartonQuantity(100) == CartonType.SMALL_PASCAL);
Debug.Assert(GetCartonQuantity(1000) == CartonType.BABY_BOX);
Debug.Assert(GetCartonQuantity(10000) == CartonType.A485);
Note: if you put this "business knowledge" inside your enum
then you must write proper tests not only for GetCartonQuantity()
but also for CartonType
itself (to be sure values are consistent).
edited Dec 17 at 9:53
answered Dec 17 at 9:37
Adriano Repetti
9,73911441
9,73911441
add a comment |
add a comment |
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209788%2fselecting-correct-carton-based-on-qty%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown